Skip to content

Conversation

theodorejb
Copy link
Contributor

Also enabled testing on PHP 8.2, 8.3, and 8.4.

@SailingGoat
Copy link

I would love to see this merged soon.

@tiwarishubham635
Copy link
Contributor

Created #167 for this. I think we can close this one

@theodorejb
Copy link
Contributor Author

theodorejb commented Apr 4, 2025

Why was this closed? It looks like #167 copies my work without proper attribution. The additional changes there seem unrelated to fixing the PHP 8.4 deprecation, so wouldn't it be better to make them separately after merging this?

@tiwarishubham635
Copy link
Contributor

My apologies @theodorejb. Let me fix the other issue with tests and then we can push this change

@tiwarishubham635 tiwarishubham635 merged commit aca44a1 into sendgrid:main Apr 7, 2025
17 checks passed
@theodorejb theodorejb deleted the php-8.4 branch April 7, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants